Included random_state parameter for reproducibility #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one to allow fur users who want variability and don't need reproducible results.
…ans clustering reproducibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to the now closed issue #10 I added a random_state parameter to the initialisation of BaseHMM, and filtered this through to each of GaussianHMM, MultinomialHMM and HeterogeneousHMM. This includes retaining random_state as an attribute, as well as a np.random.default_rng instance.
self.rng = np.random.default_rng(random_state) --> to replace sampling from a distribution (i.e. np.random.rand() or np.random.dirichlet())
self.random_state --> used for KMeans initialisation in Gaussian and Heterogeneous HMM.