Skip to content

cleanup - #2

Draft
fnasraoui wants to merge 29 commits into
fn_psql_conecctorfrom
pgsql_connector
Draft

cleanup#2
fnasraoui wants to merge 29 commits into
fn_psql_conecctorfrom
pgsql_connector

Conversation

@fnasraoui

Copy link
Copy Markdown
Owner

Pull request

Description

Related

  • RFC
  • Related Issues: fixes #000, closed #000
  • Related docs PR

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

ZhongRuoyu and others added 8 commits May 1, 2023 20:34
This fixes build failure with Rust 1.69+. According to [^1], "the only
valid argument is `#[macro_export(local_inner_macros)]` or no argument
(`#[macro_export]`)".

The check for invalid `#[macro_export]` arguments was added in
rust-lang/rust#107911 and first released in Rust 1.69.0.

[^1]: https://github.com/rust-lang/rust/blob/1.69.0/compiler/rustc_lint_defs/src/builtin.rs#L4129

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@fnasraoui
fnasraoui force-pushed the pgsql_connector branch 2 times, most recently from 3ef6347 to 9a7caf8 Compare May 9, 2023 09:08
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@fnasraoui
fnasraoui force-pushed the pgsql_connector branch 2 times, most recently from 47f82b4 to 2d22d4a Compare May 15, 2023 10:06
Licenser added 7 commits May 17, 2023 12:41
Signed-off-by: Heinz Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
…nd messages

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@fnasraoui
fnasraoui force-pushed the pgsql_connector branch 2 times, most recently from 7feb7be to 89bec27 Compare May 24, 2023 08:42
Licenser and others added 7 commits May 25, 2023 17:46
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: GitHub actions <noreply@github.com>
Signed-off-by: ferjani nasraoui  <ferjaninasraouiyt@gmail.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: ferjani nasraoui  <ferjaninasraouiyt@gmail.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: ferjani nasraoui  <ferjaninasraouiyt@gmail.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: ferjani nasraoui  <ferjaninasraouiyt@gmail.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Licenser and others added 5 commits June 1, 2023 13:28
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: fn500i <fnasraoui@wayfair.com>

adding integration tests

Signed-off-by: fn500i <fnasraoui@wayfair.com>

fixing asserts , ignore oids and wal Lsns

Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Signed-off-by: fn500i <fnasraoui@wayfair.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants