Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Delegate methods that accept keywords from Fog::Collection t… #296

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Reapply "Delegate methods that accept keywords from Fog::Collection t… #296

merged 1 commit into from
Dec 22, 2023

Conversation

DimitriosLisenko
Copy link
Contributor

…o Array correctly for Ruby 2.x and Ruby 3.x (#292)" (#295)

This reverts commit 917bcb7.

…o Array correctly for Ruby 2.x and Ruby 3.x (#292)" (#295)

This reverts commit 917bcb7.
@geemus geemus merged commit 3467e45 into fog:master Dec 22, 2023
6 checks passed
@geemus
Copy link
Member

geemus commented Dec 22, 2023

Thanks again. I imagine this deserves a release too?

@DimitriosLisenko
Copy link
Contributor Author

Agree, though I don't think it's necessarily urgent to release because most Array methods actually don't accept keywords, I think the only ones ATM are Array#shuffle, Array#sample, and Array#pack (and maybe whatever else people have monkey patched Array with). Up to you, I imagine it can wait until after the holidays.

@geemus
Copy link
Member

geemus commented Dec 22, 2023

Ah yeah, good point. Yep, my inclination was definitely to wait until the new year as I'm going to be otherwise occupied and would hate to accidentally push a bad release and be unavailable to address it.

@geemus
Copy link
Member

geemus commented Jan 3, 2024

This should now be released in v2.4.0, thanks again!

@DimitriosLisenko
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants