fix: don't error if lspconfig is not installed #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am in the same boat. Not using Can we reimplement the functions in |
I have stopped using neoconf, so that would probably have to be done by someone else in a separate PR |
|
This PR is stale because it has been open 60 days with no activity. |
|
Not merging this. It needs lspconfig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't use lspconfig, but I currently use neoconf to tell neodev which plugins to load include in the lua-language-server's
workspace.library(withlspconfig = false).Since i removed lspconfig from my plugins, neoconf errors because it expects it to be installed.
This PR adds some checks to prevent that from happening.
I'm not sure if neoconf is useful without lspconfig (neodev is still adding the neovim lua API, but it doesn't seem to pick up the plugin lists in neoconf.json anymore).