fix(config): obey notify setting for config validation #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
validation errors should always be shown since this means there's issues with your config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Obeys notify field for config validation.
Even when calling setup before register, as suggested in linked issue, deprecation warnings still results in the notification being shown, while some other warnings, like overlapping mappings or missing dependencies will not trigger the notification.
It is not clear from checkhealth what warnings will result in the message and which will not.
I would assume notify = false would hide all notifications.
This PR adds a check of notify flag in validation before sending the notification
Related Issue(s)