Fix "$tab.activate.tab" called after renavigate wrongly

[mvorisek]

fix #3156

Currently, the only "fetch" is invoked after https://github.com/fomantic/Fomantic-UI/blob/13b76ee714/src/definitions/modules/tab.js#L367 thus the "navigation" should be always active when the tab "is beiing activated and loading".

[mvorisek]

The impl. is working.

I still have one question - https://github.com/fomantic/Fomantic-UI/blob/13b76ee714/src/definitions/modules/tab.js#L482 - what is activeTabPath variable for?

It seems it is set only within the actual tab, not set of tabs, and in my testing, it was always set to the fetched tab even if the tab was changed until loaded, ie. the condition was always true.

I am not sure what the variable is for, IMO, it is useless and wrong, as other code is checking if the navigation/tab is active always using DOM - https://github.com/fomantic/Fomantic-UI/blob/13b76ee714/src/definitions/modules/tab.js#L550-L554.

[mvorisek]

Hi @lubber-de, might I have your review?

[lubber-de]

Hi @lubber-de, might I have your review?

Quickly looking at the logic, the activeTabPath should be set to the latest clicked tab, so whenever it changes in between the ajax request, tabPath should not be equal to activeTabPath anymore, thus isn't active, so the additional check should not be needed.
However, given your examples, it doesn't seem to work as expected as especially the wrong tab gets updated.

Yes, also the later check for the active class seems not quite right as you pointed out.

I have to debug all of this using some simplfied testcase myself. I suspect something else / more we need to fix.

[mvorisek]

I am marking this PR as draft to prevent unintentional merge.