Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Add get_freq_ind #297

Merged
merged 16 commits into from
Mar 12, 2025
Merged

[ENH] - Add get_freq_ind #297

merged 16 commits into from
Mar 12, 2025

Conversation

TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Jul 26, 2023

Adds a helper function for getting frequency indices

Edit: at one point, this was a placeholder for peak heights, but there's not much code on this branch and keeping it open and merging it up doesn't make sense - I'll merge the minor code in from here and re-open a proper PR for the real peak height updates

@TomDonoghue TomDonoghue added the 2.0 Targetted for the specparam 2.0 release. label Jul 26, 2023
@TomDonoghue TomDonoghue changed the base branch from main to name July 26, 2023 05:51
@fooof-tools fooof-tools deleted a comment from codecov-commenter Jul 26, 2023
@fooof-tools fooof-tools deleted a comment from codecov-commenter Aug 3, 2023
@voytek
Copy link
Contributor

voytek commented Aug 4, 2023

Does our conversation on Slack #specparam affect this at all? I think it looks good.

Base automatically changed from name to main September 23, 2023 03:08
@fooof-tools fooof-tools deleted a comment from codecov-commenter Feb 15, 2024
@fooof-tools fooof-tools deleted a comment from VascoSch92 Feb 27, 2024
@fooof-tools fooof-tools deleted a comment from codecov-commenter Mar 27, 2024
@TomDonoghue TomDonoghue mentioned this pull request Apr 4, 2024
11 tasks
@TomDonoghue TomDonoghue changed the title [WIP] - Update procedures to specify spacing & additive model for peak heights [WIP] - Add support for peak height spacing Apr 4, 2024
@fooof-tools fooof-tools deleted a comment from codecov bot Mar 11, 2025
@TomDonoghue TomDonoghue changed the title [WIP] - Add support for peak height spacing [ENH] - Add get_freq_ind Mar 12, 2025
@TomDonoghue TomDonoghue merged commit 7de637f into main Mar 12, 2025
7 checks passed
@TomDonoghue TomDonoghue deleted the peakheights branch March 12, 2025 02:34
@fooof-tools fooof-tools deleted a comment from codecov bot Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Targetted for the specparam 2.0 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants