feat: Style gameplay view #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added some adjustments, not perfect but probably a little better. I think improving scoreboard and logger would cost us much more additional work, not sure if its worth the time or not. |
mrapacz
approved these changes
Nov 29, 2017
There was a problem hiding this comment.
LGTM, still far from perfect (as you mentioned, we would probably have to work a lot on logging + scores and I think we should definitely do it, but probably not now. Our main goal right now is to add as much data as possible, not necessarily refactor things)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improvements of gameplay view
Related issues
#141
Screenshots
