refactor(elm): Split update #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have done a lot of stuff here, but it all boils down to the main Update.elm and Msgs.elm. I have split these modules so that right now specific messages and updates are delegated to the submodules, thus allowing us to have clearer and more legible code.
As for the last three TODOs, I have created independent issues for dealing with them.
TODO
Fix Room subscriptions
Split update to submodules
Resolve LeaveRoom conflict
Fix functions calling the main Update
Fix token issues as in Token przypal #211
[ ] De-couple Lobby and Room[ ] Rename General to Lobby[ ] Merge the three separate ToastiesRelated issues
#56
Test plan
manual