Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(elm): Separate models #218

Merged
merged 13 commits into from
Apr 21, 2018
Merged

refactor(elm): Separate models #218

merged 13 commits into from
Apr 21, 2018

Conversation

mrapacz
Copy link
Collaborator

@mrapacz mrapacz commented Mar 6, 2018 •
edited
Loading

Summary

TODO

  • Rename General to Lobby
  • Decouple General and Lobby
  • Get rid of the General folder
  • Move the socket part to room only?
    - [ ] Make urls part of the separated models? (Get rid of the location in sub-models)
  • Introduce alphabetical order in records

Related issues
closes: #215, #217, #214
Test plan

pmrukot
pmrukot approved these changes Apr 21, 2018
View reviewed changes
Copy link
Collaborator

@pmrukot pmrukot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrapacz
Copy link
Collaborator Author

mrapacz commented Apr 21, 2018

@pmrukot

@pr

@mrapacz mrapacz closed this Apr 21, 2018
@mrapacz mrapacz reopened this Apr 21, 2018
@mrapacz mrapacz merged commit 7af4177 into master Apr 21, 2018
@mrapacz mrapacz deleted the enhancement/separate-models branch April 21, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrukot pmrukot pmrukot approved these changes

Assignees
No one assigned
Labels
Status: Accepted Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename General to Lobby
2 participants
@mrapacz @pmrukot