fix(addict): Make "mix test" work once again #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrapacz
changed the title
pmrukot
approved these changes
Jul 13, 2017
There was a problem hiding this comment.
Looks good to me, tested manually and it works.
Just a question, do we want this test to be commented out or maybe just delete it?
https://github.com/pmrukot/aion/pull/46/files#diff-f56a5efc91128f8461d86e9a5fb06ae8R14
|
Ah, you're right, must have overlooked it and forgotten to fix this after fixing all test setups. I will update the correct version and I suppose we're good to go with merging this branch. |
mrapacz
force-pushed
the
fix/addict-tests
branch
from
6120344 to
6f2eb7f
Compare
mrapacz
added a commit
that referenced
this pull request
Aug 15, 2017
mrapacz
added a commit
that referenced
this pull request
Aug 15, 2017
mrapacz
added a commit
that referenced
this pull request
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings back the ability to run
mix testthanks to creation of test_session in AddictRelated issues
Unblocks: #24
It makes #39 less urgent
#21 now makes sense
Test plan
mix test