Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(elm): Add notification on player joining the room #57

Merged
merged 5 commits into from
Aug 16, 2017

Conversation

mrapacz
Copy link
Collaborator

@mrapacz mrapacz commented Jul 16, 2017

Summary
I put the 'blocked' label as we're still waiting for a tool that would let us display notifications in an elegant manner (by elegant I mean different than Debug.log).

There are two different types of messages depending on whether you join the channel or someone else. To make sure if it's you or someone else I compare values of currentUser.name and the name of user who has just joined.

Of course it's not the proper way to do it, it will be faulty as soon as we get two users with the same nicknames in the same room. (or maybe nicknames should be unique?). Anyway I prefer that a better way to identify players would be by using their encoded ids (see: #56).
Related issues
closes: #30

Test plan
Join a single room with two users and watch the notifications written to the log.

@mrapacz
Copy link
Collaborator Author

mrapacz commented Aug 15, 2017

I thought we were going to use toasty notifications for people joining the room, but since it's not the case, I'll just fix conflicts and merge it with master.

@mrapacz mrapacz merged commit 56333df into master Aug 16, 2017
@mrapacz mrapacz deleted the feature/notify-on-player-join branch August 16, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notification on player joining room
2 participants