feat(elm): Add form for creating a category #76
Conversation
aion/web/elm/src/Panel/Api.elm
Outdated
| import Room.Models exposing (RoomsData) | ||
|
|
||
|
|
||
| -- create question section | ||
|
|
||
|
|
||
| createQuestionUrl : String |
There was a problem hiding this comment.
I think you can move the Urls to Constants.elm
| import Toasty.Defaults | ||
|
|
||
|
|
||
| categoryFormValidationErrorToast : ( Model, Cmd Msg ) -> ( Model, Cmd Msg ) |
There was a problem hiding this comment.
Here I have a similar comment as to the previous PR. If we've put three functions mirroring three types of notifications in src/Notifications.elm, then this file could only consist of three strings + import Notifications. I think that would make it simpler, but, as I said, we can delay it until we'll be dealing with global elm refactor.
| categoryNameValidations = | ||
| let | ||
| categoryNameRegex = | ||
| "\\b([A-Z][a-z]+)\\b" |
There was a problem hiding this comment.
^\s*(.+?)\s+$
You could do this for multi word categories. Did you check how your regex behaves when dealing with Unicode characters?
aion/web/elm/src/Update.elm
Outdated
| @@ -50,6 +52,24 @@ update msg model = | |||
| _ -> | |||
| model ! [] | |||
|
|
|||
| OnCategoryCreated response -> | |||
| case response of | |||
| RemoteData.Success responseData -> | |||
There was a problem hiding this comment.
This just cries for a proper setter method, cannot wait for #56
|
Updated branch and adjusted code to your suggestions. Lets leave regex discussion for another day.. |
|
|
Summary
Related issues
Closes #41
Test plan
Just test the form