@W-19628153: [Android][QRCode] When Auth Config "Use the native browser for user authentication on Android" is enabled users logging in via QR code still challenged with browser login #2764
Conversation
…er for user authentication on Android" is enabled users logging in via QR code still challenged with browser login
| fetchAuthenticationConfiguration { | ||
| if (isBrowserLoginEnabled) { | ||
| /* Browser-based authentication is applicable when not authenticating with a front-door bridge URL */ | ||
| if (isBrowserLoginEnabled && !viewModel.isUsingFrontDoorBridge) { |
There was a problem hiding this comment.
Since the front door bridge URL will sign the user in automatically, there's no need to display the native browser for username and password authentication if the view model indicates a front door bridge is in use. Note, this property on the view model is only set for the lifetime of a single front door bridge login event.
There was a problem hiding this comment.
Thank you for that note, it preempted the question I was going to ask. 🚀
There was a problem hiding this comment.
🤣 You asked the same question on the previous pull request. We're creatures of habit!
|
I cherry-picked this to Salesforce app's current MSDK fork and verified my Advanced Authentication enabled app, user and org was able to log in successfully. |
|
Note: This pull request supersedes #2762 until the requirements for further changes are fully defined. |
|
The CI test failures are inherited from |
JohnsonEricAtSalesforce
merged commit b302878
into
forcedotcom:dev
JohnsonEricAtSalesforce
deleted the
bugfix/w-19628153_android-qrcode-when-auth-config-use-the-native-browser-for-user-authentication-on-android-is-enabled-users-logging-in-via-qr-code-still-challenged-with-browser-login
branch
🎸 Ready For Review 🥁
This brings the fix for front door bridge login and advanced authentication from #2762 into a stand-alone pull request.