Skip to content

Use sky instead of mock to fix login activity tests. #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use sky instead of mock to fix login activity tests. #2773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/LoginViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
import androidx.arch.core.executor.testing.InstantTaskExecutorRule
import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.test.platform.app.InstrumentationRegistry
import io.mockk.mockk
import io.mockk.verify
import com.salesforce.androidsdk.R.string.oauth_display_type
import com.salesforce.androidsdk.app.SalesforceSDKManager
import com.salesforce.androidsdk.auth.OAuth2.getFrontdoorUrl
Expand All @@ -40,6 +38,8 @@
import com.salesforce.androidsdk.security.SalesforceKeyGenerator.getSHA256Hash
import com.salesforce.androidsdk.ui.LoginActivity.Companion.ABOUT_BLANK
import com.salesforce.androidsdk.ui.LoginViewModel
import io.mockk.spyk
import io.mockk.verify
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
Expand Down Expand Up @@ -203,13 +203,14 @@
@Test
fun clearWebViewCache_CallsWebViewClearCache_WithTrueParameter() {
// Arrange
val mockWebView = mockk<WebView>(relaxed = true)

val webView = WebView(context)

Check failure on line 206 in libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/LoginViewModelTest.kt

View workflow job for this annotation

GitHub Actions / SalesforceSDK Test Results | api_35_test_result.xml

LoginViewModelTest.clearWebViewCache_CallsWebViewClearCache_WithTrueParameter 

java.lang.RuntimeException: WebView cannot be initialized on a thread that has no Looper.
	at android.webkit.WebView.<init>(WebView.java:436)
Raw output 
java.lang.RuntimeException: WebView cannot be initialized on a thread that has no Looper.
	at android.webkit.WebView.<init>(WebView.java:436)
	at android.webkit.WebView.<init>(WebView.java:364)
	at android.webkit.WebView.<init>(WebView.java:346)
	at android.webkit.WebView.<init>(WebView.java:333)
	at android.webkit.WebView.<init>(WebView.java:323)
	at com.salesforce.androidsdk.auth.LoginViewModelTest.clearWebViewCache_CallsWebViewClearCache_WithTrueParameter(LoginViewModelTest.kt:206)
val webviewSpy = spyk<WebView>(webView)

// Act
viewModel.clearWebViewCache(mockWebView)
viewModel.clearWebViewCache(webviewSpy)

// Assert
verify { mockWebView.clearCache(true) }
verify { webviewSpy.clearCache(true) }
}

private fun generateExpectedAuthorizationUrl(
Expand Down
Loading