Simplify build architecture of lsp worker server in apex-ls #130
+1,536
−495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewalke
commented
Sep 23, 2025
| 'precise', | ||
| ); | ||
|
|
||
| // TODO: remove this. Why doesn't the symbol manager have the symbol table? |
There was a problem hiding this comment.
This is what I'm stuck with on getting the web hovers to work :/
kylewalke
commented
Sep 23, 2025
| * Try to find a symbol by directly parsing the document when symbol manager doesn't have it | ||
| * This is a fallback mechanism for when symbol processing hasn't completed yet | ||
| */ | ||
| private async tryDirectDocumentParsing( |
There was a problem hiding this comment.
Definitely don't think we need to be reparsing the whole doc. Something else is missing.
- Remove FileSystemWatcher from web LanguageClient to prevent cloning errors - Simplify initialization options to only include serializable data - Preserve output channel functionality through notification handlers - Fix web extension launch configuration to use correct entry points - Update package.json to use dist/extension.js for desktop and dist/extension.web.js for web Resolves web worker postMessage cloning errors while maintaining debugging capabilities.
chore: consolidate configuration change listeners and add initial configuration support - Remove duplicate registerConfigurationChangeListener function from language-server.ts - Use centralized configuration listener from configuration.ts - Add sendInitialConfiguration function for startup configuration - Fix configuration section references (remove non-existent 'apex' section) - Update imports and exports for consolidated configuration management - Add proper logging for configuration changes and initial setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.