feat: added RunRelevantTests test-level @W-20152151@ #1644
Conversation
| "mime": "2.6.0", | ||
| "minimatch": "^9.0.5", | ||
| "proxy-agent": "^6.4.0", | ||
| "semver": "^7.7.3", |
There was a problem hiding this comment.
semver is a library I've used in other places (e.g., Code Analyzer) to do semantic version comparison.
|
|
||
| # error_invalid_test_level | ||
|
|
||
| TestLevel cannot be '%s' unless API version is %s or later |
There was a problem hiding this comment.
I imagine this message needs to go through some kind of review from a tech writer?
| public constructor(options: MetadataApiDeployOptions) { | ||
| super(options); | ||
| options.apiOptions = { ...MetadataApiDeploy.DEFAULT_OPTIONS.apiOptions, ...options.apiOptions }; | ||
| validateOptions(options); |
There was a problem hiding this comment.
Ordinarily, I dislike putting errors in a constructor, but doing it here lets us fail faster at the immediate point of invalidity instead of waiting to do it somewhere else.
| apiOptions: { | ||
| testLevel: 'RunRelevantTests', | ||
| }, | ||
| apiVersion: '8.0', // Tricksy case here: 8.0 is alphabetically after "66.0" but semantically after it. |
There was a problem hiding this comment.
mocha doesn't have it.each(), so it's harder to write parameterized tests. I chose to have the tricksiest case be the one I wrote. I'm fine manually adding others if we want. (Sidebar: Do we plan to stay on Mocha indefinitely, or is there a plan to migrate this repo to something like vitest or jest?)
| return fileResponses; | ||
| }; | ||
|
|
||
| const validateOptions = (options: MetadataApiDeployOptions): void => { |
There was a problem hiding this comment.
Tried to keep this method open-ended so we can expand on it in the future as needed.
Question: is there a reason for the const x = () => {} instead of function x() {} syntax?
What does this PR do?
Adds support for the new
RunRelevantTeststest level, and validation to ensure that this option is only available in API version 66.0 or later.What issues does this PR fix or reference?
@W-20152151@
Functionality Before
The only TestLevel options were
NoTests,RunLocalTests,RunAllTestsInOrgandRunSpecifiedTests.Functionality After
A new
RunRelevantTestsoption is available.