Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--force-drop-function command line parameter added. #104

Open
wants to merge 2 commits into
base: next_release
Choose a base branch
from

Conversation

vchimishuk
Copy link

Hi.
I had some problems with updating functions with your diff utility. When function's signature were changed CREATE OR REPLACE statement fails, so I have added new --force-drop-function command line key to insert DROP FUNCTION statement before any CREATE OR REPLACE statement for existing functions. This is a little redundant, but it works. It is hard to me to differ function signature change situations and insert DROP FUNCTION only in that case.
So, in some case this pull request can be interpreted as bug report, it is better to replace my patch with handling signature change situations and generates DROP FUNCTION only for such situations.
Best regards, Viacheslav.

@fordfrog
Copy link
Owner

hi, could you please provide some test cases where apgdiff fails without your patch? i just reviewed apgdiff code and it should parse function signatures and behave accordingly. but sure there might be a bug which causes it fails in some cases.

@chadfurman
Copy link
Collaborator

This PR is over 4 years old with no follow-up. I'm closing it if I don't hear from @vchimishuk soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants