Add an option prefer-updates-over-default #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using default on add column on existing table may take long and It can a good idea to prevent It by performing an update on the new column
see "Tip: Adding a column..."
https://www.postgresql.org/docs/9.6/ddl-alter.html
I created a new option called "--prefer-updates-over-default"
If activated It will generate :
ALTER TABLE testtable
ADD COLUMN IF NOT EXISTS field5 boolean;
UPDATE testtable SET field5=false WHERE field5 is null;
ALTER TABLE testtable ALTER COLUMN field5 SET DEFAULT false;
ALTER TABLE testtable ALTER COLUMN field5 SET NOT NULL;
instead of :
ALTER TABLE testtable
ADD COLUMN IF NOT EXISTS field5 boolean DEFAULT false NOT NULL;