Skip to content

[integer] Refine normalization of BigUInt division so that correction is no longer needed #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forfudan merged 3 commits into from
Jul 6, 2025
Merged

[integer] Refine normalization of BigUInt division so that correction is no longer needed #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2186986
Optimize normalization of dividend and divisor to avoid correction
forfudan Jul 6, 2025
18df571
Add scale_up_inplace_by_power_of_10
forfudan Jul 6, 2025
7e8a477
Add scale_up_inplace_by_power_of_10()
forfudan Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/decimojo/bigdecimal/arithmetics.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ fn true_divide(
# Scale up the dividend to ensure sufficient precision
var scaled_x1 = x1.coefficient
if additional_digits > 0:
scaled_x1 = scaled_x1.scale_up_by_power_of_10(additional_digits)
scaled_x1.scale_up_inplace_by_power_of_10(additional_digits)

# Perform division
var quotient: BigUInt
Expand Down Expand Up @@ -382,7 +382,7 @@ fn true_divide_inexact(
# Scale up the dividend to ensure sufficient precision
var scaled_x1 = x1.coefficient
if buffer_digits > 0:
scaled_x1 = scaled_x1.scale_up_by_power_of_10(buffer_digits)
scaled_x1.scale_up_inplace_by_power_of_10(buffer_digits)

# Perform division
var quotient: BigUInt = scaled_x1 // x2.coefficient
Expand Down
Loading