-
Notifications
You must be signed in to change notification settings - Fork 1
[decimal] Optimize multiply() with UInt128 and UInt256
#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Bench before change: |
Owner
Author
|
Bench after change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes in the
decimojoproject, focusing on enhancing themultiply()function withUInt128andUInt256. The performance of multiplication is significantly improved.Enhancements to
Decimalstruct:src/decimojo/decimal.mojo: Addedraiseskeyword to__mul__methods and introduced new methodsis_uint32ableandis_uint64ableto check if the coefficient can be represented asUInt32orUInt64values. [1] [2] [3]Improvements to rounding functionality:
src/decimojo/maths/rounding.mojo: Modified theroundfunction to include default values fordecimal_placesand updated comments for better clarity. [1] [2]Updates to utility functions:
src/decimojo/utility.mojo: Replacednumber_of_significant_digitswithnumber_of_digits, and added new functionstruncate_to_digitsandnumber_of_bitsfor better digit and bit manipulation. [1] [2] [3] [4]Enhancements to testing:
tests/test_utility.mojo: Updated tests to reflect changes in utility functions, including new tests fortruncate_to_digitsand replacing tests fornumber_of_significant_digitswithnumber_of_digits. [1] [2] [3] [4]Additional changes:
mojoproject.toml: Added individual benchmark commands forbench_multiply.mojoandbench_divide.mojo.