-
Notifications
You must be signed in to change notification settings - Fork 1
[decimal] Optimize divide() and replace string-based approach with int-based approach
#21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Bench before changes: |
Owner
Author
|
Bench after changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on optimizing
divide()by replacing string-based approach with int-based approach. It significantly improves the performance ofdivide()by from x100 to x10000 times.Advanced Overflow Prevention - Precise coefficient bounds checking with proper truncation to maintain accurate results within the 96-bit limitation, particularly in division operations
Comprehensive Edge Case Handling - Special case optimizations for common scenarios (zero values, powers of 10, coefficient of 1) with proper error messages for impossible operations
Sophisticated Scale Management - Intelligent adjustment of decimal scales during arithmetic operations, preserving maximum precision while preventing overflow
Performance Optimization - Efficient binary exponentiation for power operations, specialized division algorithms, and direct bit manipulation for improved computational efficiency
These improvements reflect progress in the "make it right" and "make it fast" phases, focusing on robustness, correctness, performance, and edge case handling while maintaining the framework for future performance optimizations.