[decimal] Update comparison functions + code reorganization #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
decimojopackage, primarily focusing on reorganizing and enhancing the comparison operations for theDecimaltype. The changes include adding a newcomparisonmodule, updating theDecimalstruct to use this module, and modifying related benchmarks and tests.Key Changes:
Comparison Operations:
comparisonmodule implementing comparison operations for theDecimaltype, including functions likecompare,greater,less,greater_equal,less_equal,equal, andnot_equal(src/decimojo/comparison.mojo).Decimalstruct to use the newcomparisonmodule for comparison operations, replacing previous logic-based comparisons (src/decimojo/decimal.mojo).Code Reorganization:
logicmodule to the newcomparisonmodule and updated import statements accordingly (src/decimojo/__init__.mojo,src/decimojo/decimal.mojo,src/decimojo/maths/__init__.mojo).Benchmarks and Tests:
from_stringandcomparisonto thebenches/bench.mojofile and updated themainfunction to include these benchmarks (benches/bench.mojo).mojoproject.tomlfile to include new test and benchmark commands forcomparison(mojoproject.toml).