Skip to content

[decimal] Optimize number_of_digit + improve the performance of multiply and exp #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forfudan merged 5 commits into from
Mar 15, 2025
Merged

[decimal] Optimize number_of_digit + improve the performance of multiply and exp #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2fda65b
Use power_of_10
forfudan Mar 15, 2025
669ef8c
Use binary search for number of digits
forfudan Mar 15, 2025
ef27f64
Complete optimization to beat python
forfudan Mar 15, 2025
a857315
Update utility
forfudan Mar 15, 2025
d82343b
Switch to ubuntu for speed
forfudan Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/run_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["macos-latest"]
# os: ["ubuntu-22.04"]
# os: ["macos-latest"]
os: ["ubuntu-22.04"]

runs-on: ${{ matrix.os }}
timeout-minutes: 30
Expand Down
2 changes: 2 additions & 0 deletions benches/bench.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ from bench_sqrt import main as bench_sqrt
from bench_from_float import main as bench_from_float
from bench_from_string import main as bench_from_string
from bench_comparison import main as bench_comparison
from bench_exp import main as bench_exp


fn main() raises:
Expand All @@ -17,3 +18,4 @@ fn main() raises:
bench_from_float()
bench_from_string()
bench_comparison()
bench_exp()
2 changes: 1 addition & 1 deletion benches/bench_exp.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ fn run_benchmark(
var mojo_decimal = Decimal(input_value)
var pydecimal = Python.import_module("decimal")
var py_decimal = pydecimal.Decimal(input_value)
var py_math = Python.import_module("math")
var _py_math = Python.import_module("math")

# Execute the operations once to verify correctness
var mojo_result = dm.exponential.exp(mojo_decimal)
Expand Down
6 changes: 3 additions & 3 deletions mojoproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ debug_sqrt = "magic run package && magic run mojo tests/test_sqrt.mojo && magic
test = "magic run package && magic run mojo test tests && magic run delete_package"
t = "clear && magic run test"
test_arith = "magic run package && magic run mojo test tests/test_arithmetics.mojo && magic run delete_package"
test_div = "magic run package && magic run mojo test tests/test_division.mojo && magic run delete_package"
test_divide = "magic run package && magic run mojo test tests/test_division.mojo && magic run delete_package"
test_sqrt = "magic run package && magic run mojo test tests/test_sqrt.mojo && magic run delete_package"
test_round = "magic run package && magic run mojo test tests/test_round.mojo && magic run delete_package"
test_creation = "magic run package && magic run mojo test tests/test_creation.mojo && magic run delete_package"
Expand All @@ -46,8 +46,8 @@ test_exp = "magic run package && magic run mojo test tests/test_exp.mojo && magi
# benches
bench = "magic run package && cd benches && magic run mojo bench.mojo && cd .. && magic run delete_package"
b = "clear && magic run bench"
bench_mul = "magic run package && cd benches && magic run mojo bench_multiply.mojo && cd .. && magic run delete_package"
bench_div = "magic run package && cd benches && magic run mojo bench_divide.mojo && cd .. && magic run delete_package"
bench_multiply = "magic run package && cd benches && magic run mojo bench_multiply.mojo && cd .. && magic run delete_package"
bench_divide = "magic run package && cd benches && magic run mojo bench_divide.mojo && cd .. && magic run delete_package"
bench_sqrt = "magic run package && cd benches && magic run mojo bench_sqrt.mojo && cd .. && magic run delete_package"
bench_round = "magic run package && cd benches && magic run mojo bench_round.mojo && cd .. && magic run delete_package"
bench_from_float = "magic run package && cd benches && magic run mojo bench_from_float.mojo && cd .. && magic run delete_package"
Expand Down
Loading
Loading