-
Notifications
You must be signed in to change notification settings - Fork 1
[decimal] Implement tan(), cot(), csc(), sec() for BigDecimal
#99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
BigDecimalmodule by adding new trigonometric functions, improving precision handling, and updating test cases to ensure correctness. The most important changes include the addition of tangent, cotangent, cosecant, and secant functions, updates to thesinandcosfunctions for zero handling, and the inclusion of comprehensive test cases for the new functionality.Enhancements to
BigDecimalfunctionality:tan,cot,csc, andsecto theBigDecimalstruct, enabling calculations for tangent, cotangent, cosecant, and secant with arbitrary precision. [1] [2]sinandcosfunctions to useBigDecimal(BigUInt.ZERO)andBigDecimal(BigUInt.ONE)for better precision and consistency. [1] [2] [3]Updates to test cases:
tan,cot,csc, andsec) to the TOML test data file, covering edge cases and typical values.run_testfunction to directly compareBigDecimalobjects instead of converting them to strings for improved accuracy in assertions.test_bigdecimal_trigonometricfunction to include tests forcos,tan, andcotfunctions alongside existing tests forsinandarctan.Codebase improvements:
trigonometric.mojoto includedecimojo.bigdecimal.constants, ensuring access to constants like π for trigonometric calculations.