Replace deprecated abortDelay property with RR7 streamTimeout #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlemTuzlak
approved these changes
Jan 5, 2025
Contributor
|
@bravo-kernel thank you so much for this, I completely missed it, closing in favor of #23 due to failing checks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team forgot to remove deprecated property
abortDelayas can be seen in this changelog and confirmed in this discussion .This patch replaces it with RR7 streamTimeout. Comments in proposed code change are taken from this page as well.
As mentioned in the ticket this "probably" fixes unnoticed issues with the streaming.