Repository navigation
fix: a desktop room switch that has to ask to be let in shows the door instead of hanging on Opening - #264
Merged
Conversation
…r instead of hanging on Opening
TheCryptoDonkey
added a commit
that referenced
this pull request
Oct 7, 2026
…fixes Desktop 0.1.57 on every platform, built from release/desktop-0.1.57 at b4307cd (main 3e9c69e): pending messages in the chat (#258, #259), an optional wait before sending (#261), the room sync resend fix (#257), the rail that scrolls instead of pushing the composer off the window (#263), and a room switch that has to knock showing the door (#264). Mac signed with the release keychain and notarised; Linux and Windows built on the M4. Manifest signed with the update key; packages uploaded to apk/desktop/0.1.57 and hash-checked on the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching from the desktop rail to a room this device holds no key for (a temporary admission granted on another device, the room reaching this one through account bookmarks) sends a knock. The desktop switch overlay hides `#identity` and `#status`, so the door saying "Waiting to be admitted" and its Stop button were invisible for the whole two-minute wait: the person saw "Opening …" and nothing else. Seen on the owner's Mac with "v4v demo".
When the switch reaches the knock, the overlay is lifted, the door shown, and Stop offered at once since the wait is on a person. Let in, the switch carries on into the room as before.
Test: new chromium-desktop case in `test/desktop-room-layout.spec.ts`; fails without the fix (door hidden), passes with it. All 19 chromium-desktop tests pass, and knock.spec + workspace.spec on chromium (11).
The same room also shows no unread count in the rail, by design for now: without the key the device cannot read it. Not changed here.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DVDoqhHqdZVfn1QTYsEZhp