forked from mmcgrana/gobyexample
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from mmcgrana:master #26
Open
pull
wants to merge
148
commits into
forks-library:master
Choose a base branch
from
mmcgrana:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard library time package has support for UnixMilli - https://pkg.go.dev/time#Time.UnixMilli Updated the example to use the method on Time instead of calculating.
This way the commend renders next to the right code block
For now just the code, no output, no comments For #411
Add a link to the range sample, and remove partial mentions of this topic in string-functions since it's now covered well in strings-and-runes
It's unnecessary now
Making it a bit cleaner and easier to understand
Text Templates should come right after String Formatting
* Add example of Go generics Fixes #349 * Remove TODO * Update public link * Update GitHub action to only build with 1.18-rc1 1.17 won't successfully build the generics example
Now that we have generics, this example is not relevant. Updates #349
This encourages the use of stronger cryptographic hashes. Tools such as securego/gosec will show errors when SHA1/MD5 hashes are used.
…directive (#424) Signed-off-by: peterzhu1992 <[email protected]>
* Add embed-directive example and rename embedding to struct-embedding Signed-off-by: peterzhu1992 <[email protected]> * Minor tweaks Signed-off-by: peterzhu1992 <[email protected]> * Add some improvements Signed-off-by: peterzhu1992 <[email protected]> * Add isDir() checks for measure.go and generate.go in tools Signed-off-by: peterzhu1992 <[email protected]>
On Linux Chrome I use ALT + Arrows to go back in the browser, but instead it paginates between examples. Fixed it by checking for special key modifiers and do nothing (to the let the browser handle it). I think the user always intends a system shortcut if they use a modifier key.
Fixes #513
* Fix grammar * Reword language goals to align with Go team's comms * Mention "latest major release" assumption Fixes #532
"unwknown" -> "unknown" in default switch case panic message.
* remove unreachable code from switch in enums example * run build/tools to generate static content in /public
Co-authored-by: Eli Bendersky <[email protected]>
* Fix filename for running the http-server example * Generate the fixed HTML
* Update json.go adding example for json.NewDecoder * updated as per Contributings.md instructions
* added type assertion example * simplified example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )