Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #528

Closed
wants to merge 13 commits into from
Closed

Modernize #528

wants to merge 13 commits into from

Conversation

mifi
Copy link

@mifi mifi commented Feb 16, 2022

This awesome project is used by thousands of people every day, but now it’s getting a bit outdated and needs some love. In order to make it easier for people to contribute and improve it, I rewrote the tests the jest, as well as simplifying the scripts and dev deps a lot.

changes:

  • rewrite to jest
  • use github actions instead of travis
  • remove browser support
  • fix deprecated Buffer constructor
  • Only support node lts versions

there should be no breaking changes except it no longer tests old node versions

if you don’t agree with the project taking this direction, that’s fine. I can publish the forked module and maintain it in parallel. If you are open to these changes, then I can also probably help maintain the project if needed.

i also plan on fixing some high severity issues like node.js hard crashing on booleans.

@ljharb
Copy link
Member

ljharb commented Sep 19, 2024

Especially given that node itself has FormData now, I don't think there's really any benefit from updating syntax, and using jest is much more of a burden than most anything, but especially tape.

Additionally, no longer testing old versions might not be a breaking change immediately, but it's definitely going to end up being one - LTS status is irrelevant to semver.

If you'd like to file an issue or a PR for each specific bug, I'd love to get them fixed.

@ljharb ljharb closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants