fix: postgres timestamp casting should include timezone

Signed-off-by: Clément Salaün <[email protected]>
formancehq · Feb 5, 2024 · 905dfcd · 905dfcd
1 parent 010ab3b
commit 905dfcd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/storage/sqlstorage/transactions.go b/pkg/storage/sqlstorage/transactions.go
@@ -461,7 +461,7 @@ func (s *Store) insertTransactions(ctx context.Context, txs ...core.ExpandedTran
                                pre_commit_volumes,
                                post_commit_volumes) (SELECT * FROM unnest(
                                    $1::int[],
-                                   $2::timestamp[],
+                                   $2::timestamptz[],
                                    $3::varchar[],
                                    $4::jsonb[],
                                    $5::jsonb[],

diff --git a/pkg/storage/sqlstorage/transactions_test.go b/pkg/storage/sqlstorage/transactions_test.go
@@ -353,6 +353,9 @@ func testTransactions(t *testing.T, store *sqlstorage.Store) {
 		// Should get only the first transaction.
 		require.Equal(t, 1, cursor.PageSize)
 
+		// Transaction timestamp fetched should be equal to the timestamp of the committed transaction.
+		require.Equal(t, cursor.Data[0].Timestamp, tx3.Timestamp.Format(time.RFC3339))
+
 		cursor, err = store.GetTransactions(context.Background(), ledger.TransactionsQuery{
 			AfterTxID: cursor.Data[0].ID,
 			PageSize:  1,