fix: transactions count using metadata

formancehq · May 17, 2023 · bbc8781 · bbc8781
1 parent dc11e08
commit bbc8781
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/api/controllers/transaction_controller.go b/pkg/api/controllers/transaction_controller.go
@@ -64,7 +64,8 @@ func (ctl *TransactionController) CountTransactions(c *gin.Context) {
 		WithSourceFilter(c.Query("source")).
 		WithDestinationFilter(c.Query("destination")).
 		WithStartTimeFilter(startTimeParsed).
-		WithEndTimeFilter(endTimeParsed)
+		WithEndTimeFilter(endTimeParsed).
+		WithMetadataFilter(c.QueryMap("metadata"))
 
 	count, err := l.(*ledger.Ledger).CountTransactions(c.Request.Context(), *txQuery)
 	if err != nil {

diff --git a/pkg/api/controllers/transaction_controller_test.go b/pkg/api/controllers/transaction_controller_test.go
@@ -1199,7 +1199,12 @@ func TestTransactions(t *testing.T) {
 
 						require.Len(t, cursor.Data, 1)
 						require.Equal(t, cursor.Data[0].ID, tx3.ID)
+	rsp = internal.CountTransactions(api, url.Values{
+						"metadata[priority]": []string{"high"},
 					})
+					require.Equal(t, http.StatusOK, rsp.Result().StatusCode)
+					require.Equal(t, "1", rsp.Header().Get("Count"))
+				})
 
 					t.Run("after", func(t *testing.T) {
 						rsp := internal.GetTransactions(api, url.Values{