Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accounts): fix bloom filter empty #456

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

paul-nicolas
Copy link
Contributor

When rebooting the ledger, bloom filter will be
empty and we will never fetch the metadata and
the balances

When rebooting the ledger, bloom filter will be
empty and we will never fetch the metadata and
the balances
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 65.85% and project coverage change: -0.03% ⚠️

Comparison is base (78a58db) 64.07% compared to head (c2f7807) 64.05%.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/v1.10     #456      +/-   ##
=================================================
- Coverage          64.07%   64.05%   -0.03%     
=================================================
  Files                152      152              
  Lines              14142    14118      -24     
=================================================
- Hits                9062     9043      -19     
+ Misses              4488     4484       -4     
+ Partials             592      591       -1     
Files Changed Coverage Δ
pkg/storage/sqlstorage/accounts.go 76.95% <ø> (-0.36%) ⬇️
pkg/storage/sqlstorage/store_ledger.go 81.81% <ø> (+8.74%) ⬆️
pkg/storage/sqlstorage/aggregations.go 69.56% <65.85%> (-0.22%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flemzord flemzord merged commit ddeb74b into release/v1.10 Aug 31, 2023
19 of 20 checks passed
@flemzord flemzord deleted the fix/missing-accounts-metadata branch August 31, 2023 12:32
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants