Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove analytics #483

Open
wants to merge 1 commit into
base: release/v1.11
Choose a base branch
from
Open

chore: Remove analytics #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
uses: ./.github/workflows/template_goreleaser-build.yaml
secrets:
NUMARY_GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
SEGMENT_WRITE_KEY_OSS: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}

GoReleaserRelease:
needs:
Expand All @@ -65,7 +64,6 @@ jobs:
uses: ./.github/workflows/template_goreleaser-release.yaml
secrets:
NUMARY_GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
SEGMENT_WRITE_KEY_OSS: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}
FURY_TOKEN: ${{ secrets.FURY_TOKEN }}

SdkGenerate:
Expand Down Expand Up @@ -97,7 +95,6 @@ jobs:
RELEASE: ${{ github.event.action }}
secrets:
NUMARY_GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
SEGMENT_WRITE_KEY_OSS: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}

DockerBranch:
needs:
Expand All @@ -112,4 +109,3 @@ jobs:
RELEASE: ${{ github.event.action }}
secrets:
NUMARY_GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
SEGMENT_WRITE_KEY_OSS: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}
6 changes: 0 additions & 6 deletions .github/workflows/template_docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ on:
NUMARY_GITHUB_TOKEN:
required: true
description: GitHub token with access to the repo
SEGMENT_WRITE_KEY_OSS:
required: true
description: Segment write key for the OSS repo

jobs:
Docker:
Expand Down Expand Up @@ -54,7 +51,6 @@ jobs:
build-args: |
APP_SHA=${{ inputs.APP_SHA }}
VERSION=${{ inputs.VERSION }}
SEGMENT_WRITE_KEY=${{ secrets.SEGMENT_WRITE_KEY_OSS }}
- name: Build and push PreReleased
if: inputs.RELEASE == 'prereleased'
uses: docker/build-push-action@v2
Expand All @@ -66,7 +62,6 @@ jobs:
build-args: |
APP_SHA=${{ inputs.APP_SHA }}
VERSION=${{ inputs.VERSION }}
SEGMENT_WRITE_KEY=${{ secrets.SEGMENT_WRITE_KEY_OSS }}
- name: Build and push
if: inputs.RELEASE != 'released' || inputs.RELEASE != 'prereleased'
uses: docker/build-push-action@v2
Expand All @@ -78,4 +73,3 @@ jobs:
build-args: |
APP_SHA=${{ inputs.APP_SHA }}
VERSION=${{ inputs.VERSION }}
SEGMENT_WRITE_KEY=${{ secrets.SEGMENT_WRITE_KEY_OSS }}
5 changes: 0 additions & 5 deletions .github/workflows/template_goreleaser-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ on:
NUMARY_GITHUB_TOKEN:
required: true
description: GitHub token with access to the repo
SEGMENT_WRITE_KEY_OSS:
required: true
description: Segment write key for the OSS repo

jobs:
goreleaser:
Expand Down Expand Up @@ -37,7 +34,6 @@ jobs:
args: build --parallelism 4 --rm-dist --skip-validate --snapshot
env:
GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
SEGMENT_WRITE_KEY: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}
- name: Run GoReleaser for MacOS
if: ${{ matrix.os == 'macos-latest' }}
uses: goreleaser/goreleaser-action@v4
Expand All @@ -46,7 +42,6 @@ jobs:
args: build -f .goreleaser-darwin.yml --parallelism 4 --rm-dist --skip-validate --snapshot
env:
GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
SEGMENT_WRITE_KEY: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}
- uses: actions/upload-artifact@v2
with:
name: dist
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/template_goreleaser-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ on:
NUMARY_GITHUB_TOKEN:
required: true
description: GitHub token with access to the repo
SEGMENT_WRITE_KEY_OSS:
required: true
description: Segment write key for the OSS repo
FURY_TOKEN:
required: true
description: Fury token for the OSS repo
Expand Down Expand Up @@ -41,7 +38,6 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
FURY_TOKEN: ${{ secrets.FURY_TOKEN }}
SEGMENT_WRITE_KEY: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}
uses: goreleaser/goreleaser-action@v4
with:
version: latest
Expand All @@ -51,7 +47,6 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.NUMARY_GITHUB_TOKEN }}
FURY_TOKEN: ${{ secrets.FURY_TOKEN }}
SEGMENT_WRITE_KEY: ${{ secrets.SEGMENT_WRITE_KEY_OSS }}
uses: goreleaser/goreleaser-action@v4
with:
version: latest
Expand Down
1 change: 0 additions & 1 deletion .goreleaser-darwin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ builds:
- -X github.com/numary/ledger/cmd.BuildDate={{ .Date }}
- -X github.com/numary/ledger/cmd.Version={{ .Version }}
- -X github.com/numary/ledger/cmd.Commit={{ .ShortCommit }}
- -X github.com/numary/ledger/cmd.DefaultSegmentWriteKey={{ .Env.SEGMENT_WRITE_KEY }}
- -s
env:
- CGO_ENABLED=1
Expand Down
3 changes: 0 additions & 3 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ builds:
- -X github.com/numary/ledger/cmd.BuildDate={{ .Date }}
- -X github.com/numary/ledger/cmd.Version={{ .Version }}
- -X github.com/numary/ledger/cmd.Commit={{ .ShortCommit }}
- -X github.com/numary/ledger/cmd.DefaultSegmentWriteKey={{ .Env.SEGMENT_WRITE_KEY }}
env:
- CGO_ENABLED=1
- CC=x86_64-w64-mingw32-gcc
Expand All @@ -29,7 +28,6 @@ builds:
- -X github.com/numary/ledger/cmd.BuildDate={{ .Date }}
- -X github.com/numary/ledger/cmd.Version={{ .Version }}
- -X github.com/numary/ledger/cmd.Commit={{ .ShortCommit }}
- -X github.com/numary/ledger/cmd.DefaultSegmentWriteKey={{ .Env.SEGMENT_WRITE_KEY }}
- -extldflags "-static"
env:
- CGO_ENABLED=1
Expand All @@ -45,7 +43,6 @@ builds:
- -X github.com/numary/ledger/cmd.BuildDate={{ .Date }}
- -X github.com/numary/ledger/cmd.Version={{ .Version }}
- -X github.com/numary/ledger/cmd.Commit={{ .ShortCommit }}
- -X github.com/numary/ledger/cmd.DefaultSegmentWriteKey={{ .Env.SEGMENT_WRITE_KEY }}
- -extldflags "-static"
env:
- CGO_ENABLED=1
Expand Down
2 changes: 0 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ RUN CGO_ENABLED=1 GOOS=linux go install -v -installsuffix cgo -a std
ARG TARGETARCH
ARG APP_SHA
ARG VERSION
ARG SEGMENT_WRITE_KEY
WORKDIR /go/src/github.com/numary/ledger
# get deps first so it's cached
COPY . .
Expand All @@ -20,7 +19,6 @@ RUN --mount=type=cache,id=gobuild,target=/root/.cache/go-build \
-ldflags="-X github.com/numary/ledger/cmd.Version=${VERSION} \
-X github.com/numary/ledger/cmd.BuildDate=$(date +%s) \
-X github.com/numary/ledger/cmd.Commit=${APP_SHA} \
-X github.com/numary/ledger/cmd.DefaultSegmentWriteKey=${SEGMENT_WRITE_KEY}" ./

FROM ubuntu:jammy as app
RUN apt update && apt install -y ca-certificates wget && rm -rf /var/lib/apt/lists/*
Expand Down
2 changes: 0 additions & 2 deletions cmd/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ func resolveOptions(v *viper.Viper, userOptions ...fx.Option) []fx.Option {
RedisLockStrategy: redisLockStrategy,
}))

options = append(options, internal.NewAnalyticsModule(v, Version))

options = append(options, fx.Provide(
fx.Annotate(func() []ledger.LedgerOption {
ledgerOptions := []ledger.LedgerOption{}
Expand Down
89 changes: 0 additions & 89 deletions cmd/internal/analytics.go
View file
Open in desktop

This file was deleted.

Loading