fix: nillable object should not be initialized in empty struct (#787)

formancehq · Nov 3, 2023 · a35834a · a35834a
1 parent b5f5463
commit a35834a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/components/fctl/cmd/stack/show.go b/components/fctl/cmd/stack/show.go
@@ -28,8 +28,7 @@ var _ fctl.Controller[*StackShowStore] = (*StackShowController)(nil)
 
 func NewDefaultStackShowStore() *StackShowStore {
 	return &StackShowStore{
-		Stack:    &membershipclient.Stack{},
-		Versions: &shared.GetVersionsResponse{},
+		Stack: &membershipclient.Stack{},
 	}
 }
 
@@ -110,8 +109,7 @@ func (c *StackShowController) Run(cmd *cobra.Command, args []string) (fctl.Rende
 
 	// the stack is not active, we can't get the running versions
 	// Maybe add something in the process with sync status and store it in membership
-
-	if stack.Status != "ACTIVE" {
+	if stack.State != "ACTIVE" {
 		return c, nil
 	}
 

diff --git a/components/fctl/go.mod b/components/fctl/go.mod
@@ -7,7 +7,7 @@ require (
 	github.com/athul/shelby v1.0.6
 	github.com/c-bata/go-prompt v0.2.6
 	github.com/formancehq/fctl/membershipclient v0.0.0-00010101000000-000000000000
-	github.com/formancehq/formance-sdk-go v0.0.0-00010101000000-000000000000
+	github.com/formancehq/formance-sdk-go v1.0.202307124
 	github.com/formancehq/stack/libs/go-libs v0.0.0-00010101000000-000000000000
 	github.com/golang-jwt/jwt v3.2.2+incompatible
 	github.com/iancoleman/strcase v0.2.0