Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bucket naming length #1092

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix: bucket naming length #1092

merged 2 commits into from
Jan 8, 2024

Conversation

Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Jan 4, 2024

Bucket <-> Ledger, naming convention:

  • 63 bytes max length

Actually:

  • ledger names VARCHAR
  • bucket names VARCHAR
    => They are not constraint by the 63bytes limits

Fixes ENG-456

https://www.postgresql.org/docs/current/limits.html

@Dav-14 Dav-14 requested a review from a team as a code owner January 4, 2024 10:16
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 11:34am

@Dav-14 Dav-14 changed the title Ledger/Bucket naming fix: bucket naming length Jan 4, 2024
@Dav-14 Dav-14 changed the title fix: bucket naming length feat: bucket naming length Jan 4, 2024
@Dav-14 Dav-14 changed the title feat: bucket naming length fix: bucket naming length Jan 4, 2024
@Dav-14 Dav-14 requested a review from gfyrag January 8, 2024 11:22
@Dav-14 Dav-14 force-pushed the fix/ledger_search_path branch 2 times, most recently from 89b3c9f to 1b2585d Compare January 8, 2024 11:33
@Dav-14 Dav-14 enabled auto-merge January 8, 2024 11:37
@Dav-14 Dav-14 added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@Dav-14 Dav-14 added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 34f706d Jan 8, 2024
11 checks passed
@Dav-14 Dav-14 deleted the fix/ledger_search_path branch January 8, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants