chore(ledger): remove dead code

[ascandone]

Apparently this is dead code and deleting it doesn't cause any test to break. I cannot find this function used anywhere using lexical search around the repo
Should we delete this? Or is it exposed publicly?

[coderabbitai]

Walkthrough

The recent changes involve the complete removal of the VisitValueAwareSource method from the parseVisitor class. This method previously handled resource address retrieval for accounts within various contexts but has been eliminated, signifying a major shift in resource management within the parsing logic. As a result, the codebase may be undergoing a restructuring that alters how account resources are processed.

Changes

Files	Change Summary
components/ledger/internal/machine/script/compiler/source.go	Removed the VisitValueAwareSource method from the parseVisitor class, which eliminated the logic for retrieving account resource addresses from different contexts.

Poem

🐇 In the code where rabbits play,
A method hopped away today.
No more resource calls to chase,
A new path now, a different space.
With every change, we leap and bound,
In this code, new joys are found! 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8436bef and e28d515.

Files selected for processing (1)

• components/ledger/internal/machine/script/compiler/source.go (1 hunks)

Additional comments not posted (2)

components/ledger/internal/machine/script/compiler/source.go (2)

Line range hint 10-34:
LGTM!

The TakeFromSource method is self-contained and does not reference the removed VisitValueAwareSource method. The logic appears to be correct.

---

Line range hint 36-131:
LGTM! But verify the impact of the removed method.

The VisitSource method is complex and handles various cases. The logic appears to be correct, but ensure that the removal of the VisitValueAwareSource method does not affect its functionality.

Verification successful

---

Verification Complete: No Impact from Removed Method

The VisitSource method functions correctly, and there are no references or definitions of the VisitValueAwareSource method in the codebase. The removal of the VisitValueAwareSource method does not impact the functionality of the VisitSource method.

• No references or definitions of VisitValueAwareSource found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the removed `VisitValueAwareSource` method.

# Test: Search for references to `VisitValueAwareSource`. Expect: No references found.
rg --type go 'VisitValueAwareSource'

Length of output: 36

---

Script:

#!/bin/bash
# Description: Verify the removal of the `VisitValueAwareSource` method and check for any remaining references.

# Search for the definition of the `VisitValueAwareSource` method to confirm its removal.
rg --type go 'func VisitValueAwareSource'

# Search for any remaining references to `VisitValueAwareSource` in the codebase.
rg --type go 'VisitValueAwareSource'

Length of output: 80