feat(tools): Lock only active stacks

[flemzord]

No description provided.

[coderabbitai]

Walkthrough

This change enhances the lockAllStacks function by introducing a condition to skip locking for disabled stacks. By checking if stack.Spec.Disabled is true, the function ensures that only active stacks are processed, improving robustness and preventing errors related to modifying stacks that should remain unchanged.

Changes

File Path	Change Summary
.../kubectl-stacks/lock.go	Added a condition in lockAllStacks to skip locking for stacks marked as disabled.

Poem

In fields of code I hop and play,
With locks and stacks, I save the day.
Disabled ones, I’ll kindly skip,
For active stacks, I’ll take a trip!
Hooray for changes, bright and clear,
A joyful code, let’s all cheer! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8436bef and ec9d02b.

Files selected for processing (1)

• components/operator/tools/kubectl-stacks/lock.go (1 hunks)

Additional comments not posted (3)

components/operator/tools/kubectl-stacks/lock.go (3)

Line range hint 10-23:
LGTM!

The NewLockCommand function is well-structured and does not contain any issues.

---

Line range hint 50-69:
LGTM!

The lockStack function is well-structured and does not contain any issues.

---

42-45: LGTM! But verify the Disabled field usage in the codebase.

The added condition to skip disabled stacks improves the robustness of the function.

Ensure that the Disabled field is correctly used and initialized in the codebase.

Verification successful

---

The Disabled field appears to be well-integrated and utilized across the codebase.

The field is used in multiple files and contexts, including JSON serialization, deep copy functions, and various checks. This indicates proper integration and usage.

• components/operator/api/stack.formance.com/v1beta3/stack_types.go
• components/operator/internal/resources/legacy/stacks/init.go
• components/operator/tools/kubectl-stacks/lock.go
• components/operator/internal/core/controllers.go
• components/operator/internal/tests/auth_controller_test.go

Ensure that the Disabled field is correctly initialized and used in these locations.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `Disabled` field in the codebase.

# Test: Search for the `Disabled` field usage. Expect: Proper initialization and usage.
rg --type go 'Disabled'

Length of output: 13959

[gfyrag]

The operator do some operations even on disabled stack.