feat: Remove Auth from Gateway

[flemzord]

No description provided.

[coderabbitai]

Walkthrough

The changes in this pull request involve the removal of authentication-related features from the gateway's configuration and status management. The AuthEnabled field has been eliminated from the GatewayStatus struct, and associated authentication logic has been removed from various components, including Caddyfile templates and related functions. This results in a streamlined configuration process and a shift in how the gateway handles authentication, indicating a potential move away from using authentication mechanisms in this context.

Changes

File Path	Change Summary
components/operator/api/formance.com/v1beta1/gateway_types.go	Removed AuthEnabled field from GatewayStatus struct and its print column definition.
components/operator/internal/resources/gateways/Caddyfile.gotpl	Removed entire authentication configuration block from Caddyfile template.
components/operator/internal/resources/gateways/caddyfile.go	Modified CreateCaddyfile function to remove auth parameter, simplifying its logic.
components/operator/internal/resources/gateways/configuration.go	Modified createConfigMap function to exclude auth parameter, updating calls accordingly.
components/operator/internal/resources/gateways/init.go	Removed authentication handling logic from Reconcile function, including retrieval of Auth.
components/operator/internal/tests/gateway_controller_test.go	Removed test context for Auth object, including related setup and validation tests.
ee/gateway/pkg/plugins/auth.go	Deleted file containing JWT authentication provider implementation, including all related methods.

Possibly related PRs

• fix(operator): update Caddyfile templates to set Host header for reverse proxy #1686: The changes in this PR involve modifications to the Caddyfile templates, which are related to the overall configuration of the gateway and its handling of requests, similar to the changes made in the main PR regarding the GatewayStatus struct and the removal of authentication-related configurations.

Poem

In the meadow where bunnies play,
Authentication has hopped away.
With gateways light and free to roam,
Simplicity has found a home.
No more checks, just joy and cheer,
A world of ease is finally here! 🐇✨

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ec442e and 4b56fdb.

Files ignored due to path filters (5)

• components/operator/config/crd/bases/formance.com_gateways.yaml is excluded by !**/*.yaml
• components/operator/helm/crds/templates/crds/apiextensions.k8s.io_v1_customresourcedefinition_gateways.formance.com.yaml is excluded by !**/*.yaml
• components/operator/internal/tests/testdata/resources/gateway-controller/configmap-with-ledger-and-auth.yaml is excluded by !**/*.yaml
• ee/gateway/go.mod is excluded by !**/*.mod
• ee/gateway/go.sum is excluded by !**/*.sum, !**/*.sum

Files selected for processing (8)

• components/operator/api/formance.com/v1beta1/gateway_types.go (0 hunks)
• components/operator/docs/09-Configuration reference/02-Custom Resource Definitions.md (0 hunks)
• components/operator/internal/resources/gateways/Caddyfile.gotpl (0 hunks)
• components/operator/internal/resources/gateways/caddyfile.go (1 hunks)
• components/operator/internal/resources/gateways/configuration.go (1 hunks)
• components/operator/internal/resources/gateways/init.go (1 hunks)
• components/operator/internal/tests/gateway_controller_test.go (0 hunks)
• ee/gateway/pkg/plugins/auth.go (0 hunks)

Files not reviewed due to no reviewable changes (5)

• components/operator/api/formance.com/v1beta1/gateway_types.go
• components/operator/docs/09-Configuration reference/02-Custom Resource Definitions.md
• components/operator/internal/resources/gateways/Caddyfile.gotpl
• components/operator/internal/tests/gateway_controller_test.go
• ee/gateway/pkg/plugins/auth.go

Files skipped from review due to trivial changes (1)

• components/operator/internal/resources/gateways/caddyfile.go

Files skipped from review as they are similar to previous changes (2)

• components/operator/internal/resources/gateways/configuration.go
• components/operator/internal/resources/gateways/init.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.