Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soft delete a workflow, integration tests, fctl integration #379

Merged
merged 14 commits into from
Jul 7, 2023

Conversation

Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Jun 21, 2023

No description provided.

@Dav-14 Dav-14 requested a review from a team as a code owner June 21, 2023 15:22
@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 11:27am

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Run report for 8997dd03

Total time: 5m 3s | Comparison time: 16m 51s | Estimated savings: 11m 47s (70.0% faster)

Action Time Status Info
⬛️ SetupNodeTool(global) 0.2ms Skipped
⬛️ SetupSystemTool 0.1ms Skipped
🟩 SyncNodeProject(openapi) 0.2ms Passed
🟩 SyncSystemProject(go-libs) 0.2ms Passed
⬛️ InstallSystemDepsInProject(go-libs) 0ms Skipped
⬛️ InstallSystemDepsInProject(openapi) 0ms Skipped
⬛️ InstallSystemDepsInProject(fctl) 0ms Skipped
🟩 SyncSystemProject(integration) 0.2ms Passed
🟩 RunTarget(go-libs:mod) 5.6s Passed
🟩 SyncSystemProject(fctl) 370.8ms Passed
⬛️ InstallSystemDepsInProject(orchestration) 1.6ms Skipped
🟩 RunTarget(openapi:deps) 3.5s Passed
⬛️ InstallSystemDepsInProject(integration) 0ms Skipped
🟩 SyncSystemProject(orchestration) 368.1ms Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(orchestration:test) 2m 18s Passed SLOW
🟩 RunTarget(fctl:mod) 15.6s Passed
🟩 RunTarget(openapi:build) 1m 43s Passed
🟩 RunTarget(orchestration:lint) 1m 37s Passed
🟩 RunTarget(orchestration:build/ci) 4m 39s Passed SLOW
And 5 more...
Expanded report
Action Time Status Info
🟩 RunTarget(integration:mod) 1m 46s Passed
🟩 RunTarget(fctl:test) 1m 15s Passed
🟩 RunTarget(fctl:build/ci) 2m 33s Passed SLOW
🟩 RunTarget(orchestration:mod) 1m 57s Passed
🟩 RunTarget(fctl:lint) 1m 33s Passed
Touched files
components/fctl/cmd/orchestration/workflows/delete.go
components/fctl/cmd/orchestration/workflows/root.go
components/orchestration/internal/api/handler_delete_workflow.go
components/orchestration/internal/api/handler_delete_workflow_test.go
components/orchestration/internal/api/handler_list_instances_test.go
components/orchestration/internal/api/router.go
components/orchestration/internal/storage/migrations.go
components/orchestration/internal/storage/migrations/00004_add_deleted_on_workflowsgo
components/orchestration/internal/workflow/manager.go
components/orchestration/internal/workflow/workflow.go
components/orchestration/openapi.yaml
openapi/build/generate.json
sdks/go/README.md
sdks/go/docs/orchestration/README.md
sdks/go/docs/payments/README.md
sdks/go/docs/search/README.md
sdks/go/docs/wallets/README.md
sdks/go/docs/webhooks/README.md
sdks/go/files.gen
sdks/go/orchestration.go
sdks/go/pkg/models/operations/countaccounts.go
sdks/go/pkg/models/operations/counttransactions.go
sdks/go/pkg/models/operations/deleteworkflow.go
sdks/go/pkg/models/operations/listaccounts.go
sdks/go/pkg/models/operations/listtransactions.go
sdks/java/README.md
sdks/java/docs/orchestration/README.md
sdks/java/files.gen
sdks/java/lib/src/main/java/com/formance/formance_sdk/Orchestration.java
sdks/java/lib/src/main/java/com/formance/formance_sdk/models/operations/CountAccountsRequest.java
sdks/java/lib/src/main/java/com/formance/formance_sdk/models/operations/CountTransactionsRequest.java
sdks/java/lib/src/main/java/com/formance/formance_sdk/models/operations/DeleteWorkflowRequest.java
sdks/java/lib/src/main/java/com/formance/formance_sdk/models/operations/DeleteWorkflowResponse.java
sdks/java/lib/src/main/java/com/formance/formance_sdk/models/operations/ListAccountsRequest.java
sdks/java/lib/src/main/java/com/formance/formance_sdk/models/operations/ListTransactionsRequest.java
sdks/php/README.md
sdks/php/docs/orchestration/README.md
sdks/php/docs/payments/README.md
sdks/php/docs/search/README.md
sdks/php/docs/wallets/README.md
sdks/php/docs/webhooks/README.md
sdks/php/files.gen
sdks/php/src/Models/Operations/CountAccountsRequest.php
sdks/php/src/Models/Operations/CountTransactionsRequest.php
sdks/php/src/Models/Operations/DeleteWorkflowRequest.php
sdks/php/src/Models/Operations/DeleteWorkflowResponse.php
sdks/php/src/Models/Operations/ListAccountsRequest.php
sdks/php/src/Models/Operations/ListTransactionsRequest.php
sdks/php/src/Orchestration.php
sdks/python/README.md
sdks/python/docs/orchestration/README.md
sdks/python/docs/payments/README.md
sdks/python/docs/search/README.md
sdks/python/docs/wallets/README.md
sdks/python/docs/webhooks/README.md
sdks/python/files.gen
sdks/python/src/sdk/models/operations/__init__.py
sdks/python/src/sdk/models/operations/countaccounts.py
sdks/python/src/sdk/models/operations/counttransactions.py
sdks/python/src/sdk/models/operations/deleteworkflow.py
sdks/python/src/sdk/models/operations/listaccounts.py
sdks/python/src/sdk/models/operations/listtransactions.py
sdks/python/src/sdk/models/shared/__init__.py
sdks/python/src/sdk/orchestration.py
sdks/typescript/README.md
sdks/typescript/docs/orchestration/README.md
sdks/typescript/docs/payments/README.md
sdks/typescript/docs/search/README.md
sdks/typescript/docs/wallets/README.md
sdks/typescript/docs/webhooks/README.md
sdks/typescript/files.gen
sdks/typescript/src/sdk/models/operations/countaccounts.ts
sdks/typescript/src/sdk/models/operations/counttransactions.ts
sdks/typescript/src/sdk/models/operations/deleteworkflow.ts
sdks/typescript/src/sdk/models/operations/index.ts
sdks/typescript/src/sdk/models/operations/listaccounts.ts
sdks/typescript/src/sdk/models/operations/listtransactions.ts
sdks/typescript/src/sdk/orchestration.ts
tests/integration/suite/orchestration-workflows-list.go
tests/integration/suite/orchestration-workflows-soft-delete.go

@Dav-14 Dav-14 requested a review from gfyrag July 7, 2023 11:43
@Dav-14 Dav-14 changed the title feat: add route, test to soft delete a workflow feat: soft delete a workflow, integration tests, fctl integration Jul 7, 2023
@Dav-14 Dav-14 merged commit dc14696 into main Jul 7, 2023
8 checks passed
@Dav-14 Dav-14 deleted the feat/workflow-delete branch July 7, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants