Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fctl): delete metadata #532

Merged
merged 4 commits into from
Sep 26, 2023
Merged

feat(fctl): delete metadata #532

merged 4 commits into from
Sep 26, 2023

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Sep 21, 2023

feat: add deletion of metadata on fctl

Also fix show command, and a panic on the ledger.

@gfyrag gfyrag requested a review from a team as a code owner September 21, 2023 09:47
@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 10:29am

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Run report for 6c9557c9

Total time: 4m 21s | Comparison time: 24m 14s | Estimated savings: 19m 52s (82.0% faster)

Action Time Status Info
⬛️ SetupSystemTool 0ms Skipped
⬛️ SetupNodeTool(global) 0.1ms Skipped
🟩 SyncNodeProject(openapi) 0.1ms Passed
⬛️ InstallSystemDepsInProject(openapi) 0ms Skipped
🟩 RunTarget(openapi:deps) 1.6s Passed
🟩 RunTarget(openapi:build) 6.6s Passed
🟩 SyncSystemProject(go-libs) 0.2ms Passed
⬛️ InstallSystemDepsInProject(go-libs) 0ms Skipped
⬛️ InstallSystemDepsInProject(wallets) 0ms Skipped
🟩 SyncSystemProject(integration) 0.4ms Passed
🟩 SyncSystemProject(search) 0.4ms Passed
🟩 SyncSystemProject(fctl) 0.4ms Passed
⬛️ InstallSystemDepsInProject(orchestration) 0.3ms Skipped
🟩 SyncSystemProject(wallets) 0.3ms Passed
🟩 SyncSystemProject(orchestration) 0.6ms Passed
⬛️ InstallSystemDepsInProject(ledger) 0.3ms Skipped
⬛️ InstallSystemDepsInProject(search) 0.3ms Skipped
⬛️ InstallSystemDepsInProject(integration) 0ms Skipped
🟩 RunTarget(go-libs:mod) 3.1s Passed
⬛️ InstallSystemDepsInProject(fctl) 0ms Skipped
And 23 more...
Expanded report
Action Time Status Info
🟩 SyncSystemProject(ledger) 0.2ms Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(fctl:mod) 4.2s Passed
🟩 RunTarget(wallets:mod) 473.4ms Passed
🟩 RunTarget(orchestration:mod) 51.1s Passed
🟩 RunTarget(ledger:lint) 58.2s Passed
🟩 RunTarget(search:lint) 1m 1s Passed
🟩 RunTarget(fctl:lint) 52s Passed
🟩 RunTarget(wallets:lint) 55.1s Passed
🟩 RunTarget(orchestration:lint) 1m Passed
🟩 RunTarget(orchestration:build/ci) 1m 50s Passed
🟩 RunTarget(ledger:test) 2m 59s Passed SLOW
🟩 RunTarget(ledger:build/ci) 2m 19s Passed SLOW
🟩 RunTarget(search:test) 1m 21s Passed
🟩 RunTarget(search:build/ci) 2m 20s Passed SLOW
🟩 RunTarget(integration:mod) 1m 4s Passed
🟩 RunTarget(fctl:test) 1m 16s Passed
🟩 RunTarget(fctl:build/ci) 2m 12s Passed SLOW
🟩 RunTarget(wallets:test) 1m 41s Passed
🟩 RunTarget(wallets:build/ci) 1m 45s Passed
🟩 RunTarget(orchestration:test) 1m 56s Passed
🟩 RunTarget(ledger:mod) 1m 16s Passed
🟩 RunTarget(search:mod) 30.4s Passed
Touched files
components/fctl/cmd/ledger/accounts/delete_metadata.go
components/fctl/cmd/ledger/accounts/root.go
components/fctl/cmd/ledger/list.go
components/fctl/cmd/ledger/serverinfo.go
components/fctl/cmd/ledger/transactions/delete_metadata.go
components/fctl/cmd/ledger/transactions/root.go
components/fctl/go.mod
components/fctl/go.sum
components/ledger/internal/api/v1/controllers_info_test.go
components/ledger/internal/api/v2/controllers_transactions.go
components/ledger/internal/bus/message.go
components/ledger/internal/engine/command/commander.go
components/ledger/openapi.yaml
components/orchestration/go.sum
components/search/benthos/streams/ledger_ingestion.yaml
components/wallets/go.sum
openapi/templates/go/gen.yaml
openapi/templates/typescript/gen.yaml
tests/integration/go.mod
tests/integration/go.sum

@gfyrag gfyrag merged commit 29571f9 into main Sep 26, 2023
10 of 12 checks passed
@gfyrag gfyrag deleted the feat/fctl-delete-metadata branch September 26, 2023 10:54
Dav-14 pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants