Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): connectors can be instaciated multiple times #834

Merged
merged 11 commits into from
Nov 14, 2023

Conversation

paul-nicolas
Copy link
Contributor

@paul-nicolas paul-nicolas commented Nov 7, 2023

DESCRIPTION

This PR adds the possibility to add multiple connectors of the same PSP. It's separated in multiple commits that represents the changes in each services impacted:

  • Payments: Storage was refactor since all IDs (paymentID, accountsID, transferID etc...) have to be migrated in order to be able to handle multiple connectors of the same PSP. A migration from v0.x to v1.x was added. A lots of changes were made in the API also in order to prepare for the v1.0.0 of payments.
  • Benthos: Payment streams were modified, but the compatibility with payments v0.x was kept.
  • Operator: Remove all data from search and handle new payments version
  • FCTL: Fix with new payments API
  • Orchestration: Fix with new payments API
  • Tests/Integration: Fix with new payments API

TESTS

Testings using integrations tests, and dev env.

Fixes ENG-201

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 8:19am

@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from 9727ca2 to 898421b Compare November 7, 2023 14:04
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from 898421b to a6a5d3f Compare November 7, 2023 14:20
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from db52cbe to ed408c6 Compare November 8, 2023 13:03
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from ed408c6 to 6edcb46 Compare November 8, 2023 13:33
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from be40efa to 005573f Compare November 8, 2023 13:53
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from f7eef75 to 2fdb9e8 Compare November 8, 2023 14:31
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from 2fdb9e8 to 1df7175 Compare November 8, 2023 14:32
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from 1df7175 to e3fea72 Compare November 8, 2023 14:39
@paul-nicolas paul-nicolas marked this pull request as ready for review November 8, 2023 14:48
@paul-nicolas paul-nicolas requested a review from a team as a code owner November 8, 2023 14:48
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from e3fea72 to 4f7a5b6 Compare November 9, 2023 08:49
@paul-nicolas paul-nicolas force-pushed the feat/payments-multiple-connectors branch from 4f7a5b6 to 4d649ef Compare November 9, 2023 09:12
@paul-nicolas paul-nicolas added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit eb2ab04 Nov 14, 2023
8 checks passed
@paul-nicolas paul-nicolas deleted the feat/payments-multiple-connectors branch November 14, 2023 08:51
br-rafaelbarros pushed a commit to personal-forks/finance-stack that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants