refactor: Make postgres host port configurable #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lwagner-getmomo
changed the title
lwagner-getmomo
commented
Nov 13, 2023
There was a problem hiding this comment.
- I don't know if
refactoris the correct scope to use, but it seems to fit the bill the closest. - Where would I document this environment variable?
- I left any other ports hardcoded, because in many cases I was unsure what to name them. I'm happy to expand the PR to make all the host port forwardings configurable with the currently hardcoded values set as defaults.
| @@ -60,7 +60,7 @@ services: | |||
| timeout: 5s | |||
| retries: 5 | |||
| ports: | |||
| - "5432:5432" | |||
| - "${FORMANCE_POSTGRES_PORT:-5432}:5432" | |||
There was a problem hiding this comment.
If FOMANCE_HOST_PORT is not set, docker compose will fall back to forwarding to port 5432, resulting in the same behavior as without this change for anyone not using this configuration option. The - tells docker compose to also use the default, if the environment variable is available but left empty.
I'm open to suggestions for the naming. If there is any existing convention I'd be happy if you could point it out to me.
flemzord
approved these changes
Nov 13, 2023
gfyrag
approved these changes
Nov 13, 2023
br-rafaelbarros
pushed a commit
to personal-forks/finance-stack
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
When also running a
postgresdaemon on a machine, it's easier to reconfigure the docker host port passthrough, than reconfiguring that daemon and all the services depending upon it. The rest of the containers don't use the host port forwarding, so this change is supposed to be completely opaque to the other services running within the stack.TESTS
I did run the stack with a port other than
5432set up. The logs did not look any different from when forwarding the database port on host port5432. From what I can tell the web interface is perfectly usable.I don't know if the host port is used for anything but manually connecting to the database for introspection.