Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

refactor(multiCheckBox): Improve performance #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(multiCheckBox): Improve performance #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions src/types/multiCheckbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,18 @@ export default ngModule => {
};

// initialize the checkboxes check property
$scope.$watch('model', function modelWatcher(newModelValue) {
var modelValue, valueProp;
$scope.$watch('model.' + opts.key, function modelWatcher(modelValue) {

if (Object.keys(newModelValue).length) {
modelValue = newModelValue[opts.key];

$scope.$watch('to.options', function optionsWatcher(newOptionsValues) {
if (newOptionsValues && Array.isArray(newOptionsValues) && Array.isArray(modelValue)) {
valueProp = to.valueProp || 'value';
for (var index = 0; index < newOptionsValues.length; index++) {
$scope.multiCheckbox.checked[index] = modelValue.indexOf(newOptionsValues[index][valueProp]) !== -1;
}
$scope.$watch('to.options', function optionsWatcher(newOptionsValues) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this will do is essentially create a new watcher every time the model changes. Probably not something we want to do...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can see this could be an issue, but maybe your missing that this code is already in the repo?

With the way it is pre my changes, this watcher is created every time any section of the form model changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awe dang, you're right! Hmmm... We should probably fix that... I'll create an issue.

if (newOptionsValues && Array.isArray(newOptionsValues) && Array.isArray(modelValue)) {
var valueProp = to.valueProp || 'value';
for (var index = 0; index < newOptionsValues.length; index++) {
$scope.multiCheckbox.checked[index] = modelValue.indexOf(newOptionsValues[index][valueProp]) !== -1;
}
});
}
}, true);
}
});

});

function checkValidity(expressionValue) {
var valid;
Expand Down