Skip to content
This repository has been archived by the owner on Jan 22, 2018. It is now read-only.

refactor(radio, select): change model in view types #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sciborrudnicki
Copy link

Change variables to manipulate easy on options and add groups if first item got label attribute. In older way if you would like to change option name you cannot do it properly.

…lect

Change variables to manipulate easy on options and add groups if first item got label attribute. In older way if you would like to change option name you cannot do it properly.
@sciborrudnicki
Copy link
Author

Forgot about tests

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #48 into master will not change coverage

@@           master   #48   diff @@
===================================
  Files          19    19          
  Lines         100   100          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits          100   100          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update a1ec376...88e2aa1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88e2aa1 on Diabeu27:master into a1ec376 on formly-js:master.

aria-label="{{to.options[$index].ariaLabel}}"
class="{{to.options[$index].className}}"
ng-disabled="to.options[$index].disabled || to.disabled"
ng-value="to.options[$index].value">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the possibility of define the value property name.
Like this ng-value="to.options[$index][to,valueProp || 'value']".

Same goes to the next line,
{{to.options[$index].name
replaced by
{{to.options[$index][to.labelProp || 'name']

What do you say?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants