Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion Fix ]GitHub Action Fails Due to Unsupported Encoding in check_images_in_pr.py line 67 #226

Merged
merged 5 commits into from
Feb 9, 2025
Merged

[Suggestion Fix ]GitHub Action Fails Due to Unsupported Encoding in check_images_in_pr.py line 67 #226

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9acd524
GitHub Action Fails Due to Unsupported Encoding in check_images_in_pr.py
richarddushime Feb 5, 2025
2455f60
Merge branch 'master' into fix-images-checks
LukasWallrich Feb 5, 2025
0b6f7e3
Merge branch 'master' into fix-images-checks
flavioazevedo Feb 8, 2025
f826187
Merge branch 'master' into fix-images-checks
flavioazevedo Feb 8, 2025
ae00378
Merge branch 'master' into fix-images-checks
richarddushime Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/webp_conversion/check_images_in_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ def is_url(image_ref):
# Check for references in text files
elif filename.lower().endswith(TEXT_EXTENSIONS) and status in ('added', 'modified'):
try:
# Fetch the file content from the PR's head SHA
contents = repo.get_contents(filename, ref=pr.head.sha)
file_content = contents.decoded_content.decode('utf-8', errors='ignore')
if contents.encoding == "base64":
file_content = contents.decoded_content.decode('utf-8', errors='ignore')
else:
print(f"Warning: Unsupported encoding '{contents.encoding}' for {filename}. Skipping.", file=sys.stderr)
continue
except GithubException as e:
print(f"Warning: Could not fetch content for {filename}. Skipping. Error: {e}", file=sys.stderr)
continue
Expand Down