Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scam Detector - Removal of Contract Similarity base bot #661

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

RCantu92
Copy link
Contributor

No description provided.

@RCantu92 RCantu92 self-assigned this Jun 24, 2024
@RCantu92 RCantu92 requested a review from Vxatz June 24, 2024 15:45
@RCantu92 RCantu92 marked this pull request as ready for review June 25, 2024 09:20
Copy link
Contributor

@Vxatz Vxatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please update the release.md (where we keep track of the changes)
  2. base_bot_additions.md contains some instructions regarding contract similarity bots, but I think we can leave it there in case we want to add one back in the future
  3. forta_explorer_mock.py has some logic which is not needed anymore if entity == '' and label_query == 'similar-contract':...

The changes made LGTM, my comments are only about things that could additionally be removed, although of lesser importance

scam-detector-py/src/findings.py Outdated Show resolved Hide resolved
scam-detector-py/src/findings_test.py Show resolved Hide resolved
@Vxatz Vxatz self-requested a review June 26, 2024 08:30
Copy link
Contributor

@Vxatz Vxatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants