Merged
Conversation
jethrogb
reviewed
Jul 12, 2019
| if !Paint::is_enabled() { | ||
| swcontrol_msg = swcontrol_msg.replace('“', r#"""#).replace('”', r#"""#).into(); | ||
| } | ||
| const SGX_DISABLED: Result<EfiSoftwareguardstatus, Rc<Error>> = Ok(EfiSoftwareguardstatus { status: SgxEnableStatus::Disabled }); |
Member
There was a problem hiding this comment.
You said this is going to be fixed in tomorrow's nightly? Then don't make these changes
Member
Author
There was a problem hiding this comment.
Well, I said that but what I meant was there is an open PR that makes the warning allow instead of deny. Jeffrey said that it is probably not a false positive, so we would have to deal with it regardless.
Member
|
bors r+ |
Contributor
Build succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.