Update time crate #556
Merged
Update time crate #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulstrackx
force-pushed
the
raoul/gh-555-update_time_crate
branch
from
99b1ebc
to
027afdd
Compare
raoulstrackx
force-pushed
the
raoul/gh-555-update_time_crate
branch
from
027afdd
to
caed948
Compare
ssavvides
reviewed
Jan 22, 2024
| @@ -42,5 +42,5 @@ byteorder = "1.1.0" # Unlicense/MIT | |||
| env_logger = "0.6" # MIT/Apache-2.0 | |||
| lazy_static = "1" # MIT/Apache-2.0 | |||
| log = "0.4" # MIT/Apache-2.0 | |||
| reqwest = "0.9" # MIT/Apache-2.0 | |||
| reqwest = { version = "0.11", features = ["blocking"] } # MIT/Apache-2.0 | |||
There was a problem hiding this comment.
do we need default features or can we default-features = false?
There was a problem hiding this comment.
Good catch! But the only default feature is default-tls. There's limited documentation, but I doubt we should disable it.
ssavvides
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555