Replacing the allocation technique in memory allocation stress test #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulstrackx
reviewed
Apr 3, 2024
NirjharRoyiitk
force-pushed
the
nr-replace-stress-test-allocation
branch
from
8249bf2
to
1ffd520
Compare
arai-fortanix
approved these changes
Apr 4, 2024
| @@ -103,22 +101,22 @@ fn wakeup_all_child_threads(pair_clone: Arc<(Mutex<bool>, Condvar)>) { | |||
| drop(started); | |||
| } | |||
|
|
|||
| fn traverse_buffer(buf: &mut Vec<i32>, scan_interval: usize) { | |||
| let mut ptr = 0; | |||
| fn traverse_buffer(buf: *mut u8, size: usize, _scan_interval: usize) { | |||
There was a problem hiding this comment.
Is it intentional that scan_interval is no longer used? Should the parameter just be removed instead?
| large_vector.resize(size, 0); | ||
|
|
||
| // Create a layout based on the size and alignment | ||
| let align = get_random_num(2, PAGE_SIZE).next_power_of_two(); |
There was a problem hiding this comment.
This works, but has a slight bias toward larger alignments. If you want the different alignments to have the same probability, you could do something like generating a number X between 0 and 12 inclusive, and then using the alignment (1 << X). Not a big deal.
|
|
||
| // Allocate memory using the global allocator | ||
| let ptr = unsafe { alloc(layout) }; | ||
| assert!(!ptr.is_null()); |
There was a problem hiding this comment.
It would also be nice to check that the allocated memory is correctly aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am replacing the Vector new functions with raw allocator functions to allocate and deallocate memory