Repository navigation
Conversation
added 7 commits
October 22, 2026 13:57
sardok
requested review from
aditijannu,
dlegalov-fortanix,
gilanghamidy,
raoulstrackx and
rui-alm
October 22, 2026 15:32
sardok
commented
Oct 22, 2026
| @@ -1 +1,3 @@ | |||
| #[cfg(platform = "nitro")] | |||
| pub mod net; | |||
| pub(crate) mod nitro; | |||
Contributor
Author
There was a problem hiding this comment.
If you ask why this is not gated behind #[cfg(platform = "nitro")] is, the current code structure is a little bit twisted. Particular the implementors of CSRApi. I avoided refactoring to keep the PR in its purpose.
tvsfx
reviewed
Oct 22, 2026
| @@ -0,0 +1,190 @@ | |||
| /* Copyright (c) Fortanix, Inc. | |||
Contributor
There was a problem hiding this comment.
How is this handled from the em-app perspective? Is this code now duplicated here?
Contributor
Author
There was a problem hiding this comment.
Yes, the point of this PR is to remove em-app dependency. So the nitro csr related functionality is re-written here by using different libraries.
sardok
commented
Oct 23, 2026
| uses: jwlawson/actions-setup-cmake@v2 | ||
| with: | ||
| cmake-version: "3.28" | ||
| cmake-version: "3.31" |
Contributor
Author
There was a problem hiding this comment.
Without this, the CI break.s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR copies the implementation of https://github.com/fortanix/rust-sgx/blob/master/em-app/src/platform/nitro.rs to vsock-proxy enclave. The motivation is removing
em-appdependency.Csris built from scratch inem-app(see it here: https://github.com/fortanix/rust-sgx/blob/master/em-app/src/csr.rs), in this PRftx-cert-builderis used.Important to mention that,
ftx-cert-build'sCsrcontainsbasicConstraints (CA=false)whileem-app'sCsrdoesn't havebasicContraints.